feat(storage): add samples and system tests for GCS bucket IP filtering operations#5
feat(storage): add samples and system tests for GCS bucket IP filtering operations#5thiyaguk09 wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new scripts to manage Google Cloud Storage bucket IP filtering configurations, including enabling, disabling, retrieving, listing, and deleting specific IP filter rules, along with corresponding system tests. The review feedback highlights three key areas for improvement: optimizing listBucketIpFilters.js to avoid redundant metadata API calls (preventing an N+1 query issue) and safely accessing metadata properties; fixing a correctness bug in enableBucketIpFilter.js where the filter mode is not updated if an existing configuration is present; and utilizing the spread operator in both enableBucketIpFilter.js and deleteBucketIpFilterRules.js to preserve other properties within the publicNetworkSource configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
3331e5e to
97e2c30
Compare
…tadata and optimize list retrieval
…mation with error handling
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
89576c0 to
f86128d
Compare
…ely clone IP ranges
2 participants
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.